Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1886423002: Avoid left shift of negative values when parsing H264 stream (Closed)

Created:
4 years, 8 months ago by jrummell
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid left shift of negative values when parsing H264 stream Emulation prevention three-byte detection only needs the previous two bytes, so limit |prev_two_bytes_| to be just two bytes. BUG=603485 TEST=test locally with clusterfuzz data Committed: https://crrev.com/2112e70060f2f7f51fe594d02884703e74f1a582 Cr-Commit-Position: refs/heads/master@{#387505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/filters/h264_bit_reader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jrummell
PTAL.
4 years, 8 months ago (2016-04-14 19:12:33 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 8 months ago (2016-04-14 19:14:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886423002/1
4 years, 8 months ago (2016-04-14 22:05:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/145134)
4 years, 8 months ago (2016-04-14 22:16:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886423002/1
4 years, 8 months ago (2016-04-14 23:43:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 01:06:25 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 01:12:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2112e70060f2f7f51fe594d02884703e74f1a582
Cr-Commit-Position: refs/heads/master@{#387505}

Powered by Google App Engine
This is Rietveld 408576698