content/browser/frame_host/render_frame_host_impl.h - Issue 1886413002: Always swap with a replacement proxy in OnSwapOut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1886413002: Always swap with a replacement proxy in OnSwapOut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Charlie's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index fa0047918cd349b68e276508f47fecaf46a398e2..fda2cf18b882eb4d26944e846320c49da4d61f82 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -581,7 +581,7 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,

RenderViewInitAfterNewProxyAndProcessKill);

FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, CrashSubframe);

FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,

- RenderViewHostPendingDeletionIsNotReused);

+ RenderViewHostIsNotReusedAfterDelayedSwapOutACK);

// IPC Message handlers.

void OnAddMessageToConsole(int32_t level,