Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1886393003: add command test, fix relative paths (Closed)

Created:
4 years, 8 months ago by Jennifer Messerly
Modified:
4 years, 8 months ago
Reviewers:
vsm, jakemac
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M lib/src/compiler/compiler.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A test/command/hello.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A test/command/hello.js View 1 chunk +17 lines, -0 lines 0 comments Download
A test/command/hello.js.map View 1 chunk +1 line, -0 lines 0 comments Download
A tool/command_test.sh View 1 chunk +10 lines, -0 lines 0 comments Download
M tool/test.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Jake may have a better test on the way, but I wanted to get something ...
4 years, 8 months ago (2016-04-14 19:28:48 UTC) #2
vsm
lgtm
4 years, 8 months ago (2016-04-14 19:34:39 UTC) #3
Jennifer Messerly
4 years, 8 months ago (2016-04-14 19:35:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
854e24eddafa6376c0b95bea367a032d15af8dcc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698