Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1886343002: Don't isolate the Skia repo for Swarming compiles (Closed)

Created:
4 years, 8 months ago by borenet2
Modified:
4 years, 7 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Better #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M infra/bots/compile_skia.isolate View 1 1 chunk +5 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (6 generated)
borenet
Depends on https://codereview.chromium.org/1916263003/ https://codereview.chromium.org/1886343002/diff/20001/infra/bots/compile_skia.isolate File infra/bots/compile_skia.isolate (right): https://codereview.chromium.org/1886343002/diff/20001/infra/bots/compile_skia.isolate#newcode4 infra/bots/compile_skia.isolate:4: '../../../.gclient', This is really just a ...
4 years, 7 months ago (2016-04-26 15:17:26 UTC) #4
rmistry
lgtm
4 years, 7 months ago (2016-04-26 15:19:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886343002/20001
4 years, 7 months ago (2016-04-27 12:54:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 13:06:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6f4c1aa8f9afe06ce4ef4a0396a7032d5c46df0f

Powered by Google App Engine
This is Rietveld 408576698