Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 188633003: Revert of Eliminate the dependence of tts extension API for tts_controller.cc (Closed)

Created:
6 years, 9 months ago by merkulova
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Eliminate the dependence of tts extension API for tts_controller.cc (https://codereview.chromium.org/181123004/) Reason for revert: Breakes ChromeVox spoken feedback on OOBE. Original issue's description: > Eliminate the dependence of tts extension API for tts_controller.cc > > This is the first patch to move TTS implementation from browser layer > to content. To move TTS to conent, the direct dependence of browser > compoent should be eliminated from TTS classes first. > > R=tommi@chromium.org, dmazzoni@chromium.org, sky@chromium.org > BUG=347045 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254740 TBR=dmazzoni@chromium.org,tommi@chromium.org,sky@chromium.org,chun.gao@intel.com NOTREECHECKS=true NOTRY=true BUG=347045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -79 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.h View 1 chunk +25 lines, -12 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/speech/tts_controller.h View 3 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/speech/tts_controller.cc View 9 chunks +13 lines, -20 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
merkulova
Created Revert of Eliminate the dependence of tts extension API for tts_controller.cc
6 years, 9 months ago (2014-03-06 14:53:37 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 14:53:45 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-06 14:53:46 UTC) #3
Nikita (slow)
lgtm
6 years, 9 months ago (2014-03-06 14:54:38 UTC) #4
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 9 months ago (2014-03-06 14:54:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/188633003/1
6 years, 9 months ago (2014-03-06 14:54:55 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 14:55:40 UTC) #7
Message was sent while issue was closed.
Change committed as 255354

Powered by Google App Engine
This is Rietveld 408576698