content/browser/renderer_host/render_widget_host_view_browsertest.cc - Issue 188633002: Query the preferred readback config in CopyFromBackingStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 188633002: Query the preferred readback config in CopyFromBackingStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for test build issue. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | content/browser/renderer_host/render_widget_host_view_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_browsertest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

index 9db52c78420354a72b10da4eca6a6238418db967..5197631c72e437477c9fab6c347cfe1d957e3fe1 100644

--- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

@@ -172,7 +172,8 @@ class RenderWidgetHostViewBrowserTest : public ContentBrowserTest {

base::Bind(

&RenderWidgetHostViewBrowserTest::FinishCopyFromBackingStore,

base::Unretained(this),

- run_loop.QuitClosure()));

+ run_loop.QuitClosure()),

+ SkBitmap::kARGB_8888_Config);

run_loop.Run();

if (frames_captured())

@@ -376,7 +377,9 @@ IN_PROC_BROWSER_TEST_P(CompositingRenderWidgetHostViewBrowserTest,

gfx::Rect(),

frame_size(),

base::Bind(&RenderWidgetHostViewBrowserTest::FinishCopyFromBackingStore,

- base::Unretained(this), run_loop.QuitClosure()));

+ base::Unretained(this),

+ run_loop.QuitClosure()),

+ SkBitmap::kARGB_8888_Config);

// Delete the surface before the callback is run.

GetRenderWidgetHostViewPort()->AcceleratedSurfaceRelease();

run_loop.Run();