chrome/browser/thumbnails/thumbnail_tab_helper.cc - Issue 188633002: Query the preferred readback config in CopyFromBackingStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_tab_helper.cc

Issue 188633002: Query the preferred readback config in CopyFromBackingStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add Preferred format support for all functions. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/capture_web_contents_function.cc ('K') | « chrome/browser/extensions/api/capture_web_contents_function.cc ('k') | content/browser/frame_host/navigation_entry_screenshot_manager.cc » ('j') | content/browser/frame_host/navigation_entry_screenshot_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/thumbnail_tab_helper.cc

diff --git a/chrome/browser/thumbnails/thumbnail_tab_helper.cc b/chrome/browser/thumbnails/thumbnail_tab_helper.cc

index 0b062794e300d47144d1363042e8c132c28852e3..a57bc32eae386ee6b6b4ddfc148750e16cd0090c 100644

--- a/chrome/browser/thumbnails/thumbnail_tab_helper.cc

+++ b/chrome/browser/thumbnails/thumbnail_tab_helper.cc

@@ -118,11 +118,13 @@ void AsyncProcessThumbnail(content::WebContents* web_contents,

ui::GetScaleFactorForNativeView(view->GetNativeView()),

&copy_rect,

&context->requested_copy_size);

+ SkBitmap::Config preferred_format =

+ render_widget_host->PreferredReadbackFormat();

render_widget_host->CopyFromBackingStore(

copy_rect,

context->requested_copy_size,

- base::Bind(&ProcessCapturedBitmap, context, algorithm));

+ base::Bind(&ProcessCapturedBitmap, context, algorithm),

+ preferred_format);

piman 2014/03/10 18:27:20 I believe the receiving path expects 8888 bitmaps.

sivag 2014/03/11 14:41:50 Done.

}

} // namespace