content/common/gpu/client/gl_helper.cc - Issue 188633002: Query the preferred readback config in CopyFromBackingStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gl_helper.cc

Issue 188633002: Query the preferred readback config in CopyFromBackingStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_impl.cc ('K') | « content/common/gpu/client/gl_helper.h ('k') | content/common/gpu/client/gl_helper_readback_support.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gl_helper.cc

diff --git a/content/common/gpu/client/gl_helper.cc b/content/common/gpu/client/gl_helper.cc

index 8fe6b737a0f101fb90664b520a5ac3281d603fe8..8902d6074d8a0a584b9de0414fcd69f48a7f83b3 100644

--- a/content/common/gpu/client/gl_helper.cc

+++ b/content/common/gpu/client/gl_helper.cc

@@ -1153,6 +1153,11 @@ bool GLHelper::IsReadbackConfigSupported(SkBitmap::Config texture_format) {

return readback_support_.get()->IsReadbackConfigSupported(texture_format);

}

+SkBitmap::Config GLHelper::PreferredReadbackFormat() {

+ DCHECK(readback_support_.get());

+ return readback_support_.get()->PreferredReadbackFormat();

ReadbackYUVInterface* GLHelper::CopyTextureToImpl::CreateReadbackPipelineYUV(

GLHelper::ScalerQuality quality,

const gfx::Size& src_size,