Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: build/standalone.gypi

Issue 1886293002: [build] Port options to support win-clang (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index eccf2f49fb0d168a476062487a55241e9240e190..a7572c3e1093c4819b976aa037bca1c53daae52b 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -946,6 +946,31 @@
}],
],
},
+ 'conditions': [
+ ['clang==1', {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ # Don't warn about unused function parameters.
+ # (This is also used on other platforms.)
+ '-Wno-unused-parameter',
+ # Don't warn about the "struct foo f = {0};" initialization
+ # pattern.
+ '-Wno-missing-field-initializers',
+
+ # Many files use intrinsics without including this header.
+ # TODO(hans): Fix those files, or move this to sub-GYPs.
+ '/FIIntrin.h',
+
+ # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
+ '-Wno-microsoft-enum-value', # http://crbug.com/505296
+ '-Wno-unknown-pragmas', # http://crbug.com/505314
+ '-Wno-microsoft-cast', # http://crbug.com/550065
+
+ '-fmsc-version=1900',
Nico 2016/04/14 13:54:12 1900 means msvc2015. If you're still on 2013, you
Michael Achenbach 2016/04/14 14:03:42 Yea - but no point in supporting also 2013 with cl
Nico 2016/04/14 14:48:06 In general, I feel you'll have fewest problems if
+ ],
+ },
+ }],
+ ],
},
},
}], # OS=="win"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698