Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1886283002: Blacklisting applied to the form and the page (Closed)

Created:
4 years, 8 months ago by cfroussios
Modified:
4 years, 8 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blacklisting applied to the form and the page A form is blacklisted if: It has the same elements as a blacklisted form from the same site OR It appears on the same page as a blacklisted form from the same site BUG=602195 Committed: https://crrev.com/a4a7c52f6f98adf2aa9fc752c0b6e579a54476b0 Cr-Commit-Position: refs/heads/master@{#387303}

Patch Set 1 #

Patch Set 2 : Removed obfuscating mix of return trues and falses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M components/password_manager/core/browser/password_form_manager.cc View 1 1 chunk +7 lines, -9 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
vabr (Chromium)
LGTM, thanks for the fix! (Also, congrats to unblocking your @chromium.org account.) Cheers, Vaclav
4 years, 8 months ago (2016-04-14 13:11:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886283002/20001
4 years, 8 months ago (2016-04-14 13:17:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 14:03:04 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 14:05:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4a7c52f6f98adf2aa9fc752c0b6e579a54476b0
Cr-Commit-Position: refs/heads/master@{#387303}

Powered by Google App Engine
This is Rietveld 408576698