Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issue 1886243002: X87: [wasm] Refactoring pair-shift code in the instruction selector of arm and ia32. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Refactoring pair-shift code in the instruction selector of arm and ia32. port f954934d6237998f26b6784b22b1e6f02b8b430b (r35140) original commit message: BUG= Committed: https://crrev.com/8e4fbb059a5ce1dec685754b43a8db43f70f82c2 Cr-Commit-Position: refs/heads/master@{#35476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +10 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-14 07:40:06 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-14 08:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886243002/1
4 years, 8 months ago (2016-04-14 08:49:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 09:06:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:07:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e4fbb059a5ce1dec685754b43a8db43f70f82c2
Cr-Commit-Position: refs/heads/master@{#35476}

Powered by Google App Engine
This is Rietveld 408576698