Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1886233002: X87: [turbofan] Need add V8_TARGET_ARCH_X87 in src/globals.h (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Need add V8_TARGET_ARCH_X87 in src/globals.h The CL #35139 (https://codereview.chromium.org/1775323002) added V8_TARGET_ARCH_IA32 macro in src/globals.h. X87 is almost same as IA32, So It needs the V8_TARGET_ARCH_X87 macro in src/globals.h too. BUG= Committed: https://crrev.com/1c5f0badbfcebc6c8266ddab7cb297465707f236 Cr-Commit-Position: refs/heads/master@{#35464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-14 06:12:47 UTC) #2
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-14 06:22:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886233002/1
4 years, 8 months ago (2016-04-14 06:24:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 06:57:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 06:57:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c5f0badbfcebc6c8266ddab7cb297465707f236
Cr-Commit-Position: refs/heads/master@{#35464}

Powered by Google App Engine
This is Rietveld 408576698