runtime/include/dart_api.h - Issue 18862004: Call shutdown callback before the isolate is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/include/dart_api.h

Issue 18862004: Call shutdown callback before the isolate is destroyed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/include/dart_api.h

diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h

index a75932ff615b58c366e39d3c773cea89ad62b0c1..efb521a283943a343b252b9e64a091ee391ee614 100755

--- a/runtime/include/dart_api.h

+++ b/runtime/include/dart_api.h

@@ -666,9 +666,9 @@ typedef void (*Dart_IsolateUnhandledExceptionCallback)(Dart_Handle error);

/**

* An isolate shutdown callback function.

- * This callback, provided by the embedder, is called after the vm

- * shuts down an isolate. Since the isolate has been shut down, it is

- * not safe to enter the isolate or use it to run any Dart code.

+ * This callback, provided by the embedder, is called before the vm

+ * shuts down an isolate. The isolate being shutdown will be the current

+ * isolate. It is safe run Dart code.

siva 2013/07/08 22:39:27 "safe to"

Cutch 2013/07/08 22:43:24 Done.

* This function should be used to dispose of native resources that

* are allocated to an isolate in order to avoid leaks.

« no previous file with comments | « no previous file | runtime/vm/dart.h » ('j') | runtime/vm/dart_api_impl.cc » ('J')