runtime/vm/dart_api_impl.cc - Issue 18862004: Call shutdown callback before the isolate is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 18862004: Call shutdown callback before the isolate is destroyed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index c002066478bb47231c41c71f58a26106cb757d77..3cb5b75faf30eed5de5d3930c12fe9e8ce5c2e64 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -798,7 +798,13 @@ DART_EXPORT Dart_Isolate Dart_CreateIsolate(const char* script_uri,

DART_EXPORT void Dart_ShutdownIsolate() {

- CHECK_ISOLATE(Isolate::Current());

+ Isolate* isolate = Isolate::Current();

+ CHECK_ISOLATE(isolate);

+ {

+ StackZone zone(isolate);

+ HandleScope handle_scope(isolate);

+ Dart::RunShutdownCallback();

+ }

STOP_TIMER(time_total_runtime);

Dart::ShutdownIsolate();

}

« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »