runtime/vm/isolate.cc - Issue 18862004: Call shutdown callback before the isolate is destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 18862004: Call shutdown callback before the isolate is destroyed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index 14c2392cdaf4aa5329d4d8a20a14170a9ab50367..4aefd3a51ba7c72c77072033b76eef318d5f891d 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -649,10 +649,7 @@ static void ShutdownIsolate(uword parameter) {

if (!error.IsNull()) {

OS::PrintErr("in ShutdownIsolate: %s\n", error.ToErrorCString());

}

- }

- {

// Shut the isolate down.

siva 2013/07/08 21:54:39 I think this may end up accessing the deleted isol

- SwitchIsolateScope switch_scope(isolate);

Dart::ShutdownIsolate();

}

« runtime/include/dart_api.h ('K') | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »