Call shutdown callback before the isolate is destroyed

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
@@ skipping 781 matching lines @@
     }
     *error = strdup(error_obj.ToErrorCString());
   }
   Dart::ShutdownIsolate();
   return reinterpret_cast<Dart_Isolate>(NULL);
 }
 
 
 DART_EXPORT void Dart_ShutdownIsolate() {
   CHECK_ISOLATE(Isolate::Current());
+  Isolate* isolate = Isolate::Current();

[siva, 2013/07/08 22:39:27]

Move this line up and change:
CHECK_ISOLATE(isolate);

[Cutch, 2013/07/08 22:43:24]

Done.

+  {
+    StartIsolateScope start_scope(isolate);

[siva, 2013/07/08 22:39:27]

StartIsolateScope is pretty much a NOP here as
saved_isolate_ is always equal to new_isolate_

[Cutch, 2013/07/08 22:43:24]

Done.

+    StackZone zone(isolate);
+    HandleScope handle_scope(isolate);
+    Dart::RunShutdownCallback();
+  }
   STOP_TIMER(time_total_runtime);
   Dart::ShutdownIsolate();
 }
 
 
 DART_EXPORT Dart_Isolate Dart_CurrentIsolate() {
   return Api::CastIsolate(Isolate::Current());
 }
 
 
@@ skipping 3175 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success();
 }
 
 }  // namespace dart