Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: runtime/vm/dart.cc

Issue 18862004: Call shutdown callback before the isolate is destroyed (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/dart.h ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/dart_api_state.h" 8 #include "vm/dart_api_state.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flags.h" 10 #include "vm/flags.h"
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 isolate->heap()->EnableGrowthControl(); 203 isolate->heap()->EnableGrowthControl();
204 isolate->set_init_callback_data(data); 204 isolate->set_init_callback_data(data);
205 Api::SetupAcquiredError(isolate); 205 Api::SetupAcquiredError(isolate);
206 if (FLAG_print_class_table) { 206 if (FLAG_print_class_table) {
207 isolate->class_table()->Print(); 207 isolate->class_table()->Print();
208 } 208 }
209 return Error::null(); 209 return Error::null();
210 } 210 }
211 211
212 212
213 void Dart::ShutdownIsolate() { 213 void Dart::RunShutdownCallback() {
214 Isolate* isolate = Isolate::Current(); 214 Isolate* isolate = Isolate::Current();
215 void* callback_data = isolate->init_callback_data(); 215 void* callback_data = isolate->init_callback_data();
216 isolate->Shutdown();
217 delete isolate;
218
219 Dart_IsolateShutdownCallback callback = Isolate::ShutdownCallback(); 216 Dart_IsolateShutdownCallback callback = Isolate::ShutdownCallback();
220 if (callback != NULL) { 217 if (callback != NULL) {
221 (callback)(callback_data); 218 (callback)(callback_data);
222 } 219 }
223 } 220 }
224 221
225 222
223 void Dart::ShutdownIsolate() {
224 Isolate* isolate = Isolate::Current();
225 isolate->Shutdown();
226 delete isolate;
227 }
228
229
226 uword Dart::AllocateReadOnlyHandle() { 230 uword Dart::AllocateReadOnlyHandle() {
227 ASSERT(Isolate::Current() == Dart::vm_isolate()); 231 ASSERT(Isolate::Current() == Dart::vm_isolate());
228 ASSERT(predefined_handles_ != NULL); 232 ASSERT(predefined_handles_ != NULL);
229 return predefined_handles_->handles_.AllocateScopedHandle(); 233 return predefined_handles_->handles_.AllocateScopedHandle();
230 } 234 }
231 235
232 236
233 bool Dart::IsReadOnlyHandle(uword address) { 237 bool Dart::IsReadOnlyHandle(uword address) {
234 ASSERT(predefined_handles_ != NULL); 238 ASSERT(predefined_handles_ != NULL);
235 return predefined_handles_->handles_.IsValidScopedHandle(address); 239 return predefined_handles_->handles_.IsValidScopedHandle(address);
236 } 240 }
237 241
238 } // namespace dart 242 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart.h ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698