Call shutdown callback before the isolate is destroyed

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "lib/mirrors.h"
@@ skipping 631 matching lines @@
     // Print the error if there is one.  This may execute dart code to
     // print the exception object, so we need to use a StartIsolateScope.
     StartIsolateScope start_scope(isolate);
     StackZone zone(isolate);
     HandleScope handle_scope(isolate);
     Error& error = Error::Handle();
     error = isolate->object_store()->sticky_error();
     if (!error.IsNull()) {
       OS::PrintErr("in ShutdownIsolate: %s\n", error.ToErrorCString());
     }
-  }
-  {
     // Shut the isolate down.

[siva, 2013/07/08 21:54:39]

I think this may end up accessing the deleted isolate pointer in
~StartIsolateScope if this function is called by an Isolate other than the one
being shutdown.

Did you run into an issue with this?

-    SwitchIsolateScope switch_scope(isolate);
     Dart::ShutdownIsolate();
   }
 }
 
 
 void Isolate::Run() {
   message_handler()->Run(Dart::thread_pool(),
                          RunIsolate,
                          ShutdownIsolate,
                          reinterpret_cast<uword>(this));
@@ skipping 528 matching lines @@
   return func.raw();
 }
 
 
 void IsolateSpawnState::Cleanup() {
   SwitchIsolateScope switch_scope(isolate());
   Dart::ShutdownIsolate();
 }
 
 }  // namespace dart