Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

This remove the previous codepath, which performed a less
accurate conversion to YUV.

It actually faster to use the more accurate conversion, now
that we have updated to libjpeg-turbo.

z620 Performance Speed-Up:
mandrill.jpg (512x512): 1.13x
color_wheel.jpg (128x128): 1.12x

This should fix:
https://buganizer.corp.google.com/u/0/issues/28161384
https://buganizer.corp.google.com/u/0/issues/21891795

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886183002

Committed: https://skia.googlesource.com/skia/+/c7d01d3e1d3621907c27b283fb7f8b6e177c629d

[msarett, 2016-04-14 01:59:43]

Description was changed from

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

BUG=skia:
==========

to

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-18 17:57:02]

Description was changed from

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

This remove the previous codepath, which performed a less
accurate conversion to YUV.

It actually faster to use the more accurate conversion, now
that we have updated to libjpeg-turbo.

This should fix:
https://buganizer.corp.google.com/u/0/issues/28161384
https://buganizer.corp.google.com/u/0/issues/21891795

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-18 19:52:57]

Description was changed from

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

This remove the previous codepath, which performed a less
accurate conversion to YUV.

It actually faster to use the more accurate conversion, now
that we have updated to libjpeg-turbo.

This should fix:
https://buganizer.corp.google.com/u/0/issues/28161384
https://buganizer.corp.google.com/u/0/issues/21891795

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

This remove the previous codepath, which performed a less
accurate conversion to YUV.

It actually faster to use the more accurate conversion, now
that we have updated to libjpeg-turbo.

z620 Performance Speed-Up:
mandrill.jpg (512x512): 1.13x
color_wheel.jpg (128x128): 1.12x

This should fix:
https://buganizer.corp.google.com/u/0/issues/28161384
https://buganizer.corp.google.com/u/0/issues/21891795

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-04-18 19:54:20]

msarett@google.com changed reviewers:
+ djsollen@google.com, hcm@google.com, scroggo@google.com

[msarett, 2016-04-18 19:54:21]

I think I'll want to cherry pick this into nyc-dev after it lands in Skia?

[scroggo, 2016-04-18 20:04:09]

LGTM

> I think I'll want to cherry pick this into nyc-dev after it
> lands in Skia?

/cherry-pick into m50? and then into nyc-dev?

I think you also need to get the attached bugs triaged appropriately?

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
File src/images/SkJPEGImageEncoder.cpp (left):

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
src/images/SkJPEGImageEncoder.cpp:204: SkAutoTime atm("JPEG Encode");
This seems like an unrelated change. That change should delete SkAutoTime (only
used here) and perhaps SkTime.h is not needed at all? (Haven't dug further
there...)

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
File src/images/SkJPEGImageEncoder.cpp (right):

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
src/images/SkJPEGImageEncoder.cpp:2: * Copyright 2016 Google Inc.
We generally leave copyright notices unchanged after the file is initially
checked in.

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
src/images/SkJPEGImageEncoder.cpp:130: // FIXME: Can we take advantage of
additional libjpeg-turbo in_color_spaces
nit: This took me a few tries to parse. I think it might be clearer to say
something like

Can we take advantage of other in_color_spaces in libjpeg-turbo?

[msarett, 2016-04-18 21:10:47]

Patchset #3 (id:40001) has been deleted

[msarett, 2016-04-18 21:12:13]

> /cherry-pick into m50? and then into nyc-dev?

sgtm

> I think you also need to get the attached bugs triaged
> appropriately?

Gotcha thanks.

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
File src/images/SkJPEGImageEncoder.cpp (left):

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
src/images/SkJPEGImageEncoder.cpp:204: SkAutoTime atm("JPEG Encode");
On 2016/04/18 20:04:09, scroggo wrote:
> This seems like an unrelated change. That change should delete SkAutoTime
(only
> used here) and perhaps SkTime.h is not needed at all? (Haven't dug further
> there...)

Reverting Time related aspects of this change.

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
File src/images/SkJPEGImageEncoder.cpp (right):

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
src/images/SkJPEGImageEncoder.cpp:2: * Copyright 2016 Google Inc.
On 2016/04/18 20:04:09, scroggo wrote:
> We generally leave copyright notices unchanged after the file is initially
> checked in.

Done.

https://codereview.chromium.org/1886183002/diff/20001/src/images/SkJPEGImageE...
src/images/SkJPEGImageEncoder.cpp:130: // FIXME: Can we take advantage of
additional libjpeg-turbo in_color_spaces
On 2016/04/18 20:04:09, scroggo wrote:
> nit: This took me a few tries to parse. I think it might be clearer to say
> something like
> 
> Can we take advantage of other in_color_spaces in libjpeg-turbo?

Done.

[msarett, 2016-04-18 21:12:38]

The CQ bit was checked by msarett@google.com

[msarett, 2016-04-18 21:12:39]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1886183002/#ps60001
(title: "Response to comments")

[commit-bot: I haz the power, 2016-04-18 21:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886183002/60001

[commit-bot: I haz the power, 2016-04-18 21:21:57]

Description was changed from

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

This remove the previous codepath, which performed a less
accurate conversion to YUV.

It actually faster to use the more accurate conversion, now
that we have updated to libjpeg-turbo.

z620 Performance Speed-Up:
mandrill.jpg (512x512): 1.13x
color_wheel.jpg (128x128): 1.12x

This should fix:
https://buganizer.corp.google.com/u/0/issues/28161384
https://buganizer.corp.google.com/u/0/issues/21891795

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use libjpeg-turbo for YUV->RGB conversion in jpeg encoder

This remove the previous codepath, which performed a less
accurate conversion to YUV.

It actually faster to use the more accurate conversion, now
that we have updated to libjpeg-turbo.

z620 Performance Speed-Up:
mandrill.jpg (512x512): 1.13x
color_wheel.jpg (128x128): 1.12x

This should fix:
https://buganizer.corp.google.com/u/0/issues/28161384
https://buganizer.corp.google.com/u/0/issues/21891795

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/c7d01d3e1d3621907c27b283fb7f8b6e177c629d
==========

[commit-bot: I haz the power, 2016-04-18 21:21:58]

Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/c7d01d3e1d3621907c27b283fb7f8b6e177c629d