Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 1886173003: [wasm] Remove the use of JSOperatorBuilder.ToNumber to avoid JSGenericLowering. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove the use of JSOperatorBuilder.ToNumber to avoid JSGenericLowering. R=mstarzinger@chromium.org BUG=v8:4914 LOG=n Committed: https://crrev.com/15fc9d063ad9aaaf15522c13ce1f539740c9e069 Cr-Commit-Position: refs/heads/master@{#35483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 5 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 8 months ago (2016-04-14 09:46:17 UTC) #1
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-14 09:54:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886173003/1
4 years, 8 months ago (2016-04-14 10:31:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 10:33:37 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 10:34:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15fc9d063ad9aaaf15522c13ce1f539740c9e069
Cr-Commit-Position: refs/heads/master@{#35483}

Powered by Google App Engine
This is Rietveld 408576698