Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: content/renderer/media/video_track_recorder_unittest.cc

Issue 1886123002: [experimental] MR: add support for H264 recording (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/video_track_recorder.cc ('k') | media/muxers/webm_muxer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_track_recorder_unittest.cc
diff --git a/content/renderer/media/video_track_recorder_unittest.cc b/content/renderer/media/video_track_recorder_unittest.cc
index 12ed36c710c6bd88a4dd62de9fca69d4b84e25f5..0813e11ddd1aa4b3e06e2557530f05b19d9bbe96 100644
--- a/content/renderer/media/video_track_recorder_unittest.cc
+++ b/content/renderer/media/video_track_recorder_unittest.cc
@@ -40,9 +40,12 @@ ACTION_P(RunClosure, closure) {
closure.Run();
}
-const bool kTrackRecorderTestUseVp9OrNot[] = {false, true};
+const VideoTrackRecorder::CodecId kTrackRecorderTestCodec[] = {
+ VideoTrackRecorder::CodecId::VP8, VideoTrackRecorder::CodecId::VP9,
+ VideoTrackRecorder::CodecId::H264};
-class VideoTrackRecorderTest : public TestWithParam<bool> {
+class VideoTrackRecorderTest
+ : public TestWithParam<VideoTrackRecorder::CodecId> {
public:
VideoTrackRecorderTest()
: mock_source_(new MockMediaStreamVideoSource(false)) {
@@ -61,7 +64,7 @@ class VideoTrackRecorderTest : public TestWithParam<bool> {
blink_track_.setExtraData(track_);
video_track_recorder_.reset(new VideoTrackRecorder(
- GetParam() /* use_vp9 */, blink_track_,
+ GetParam() /* codec */, blink_track_,
base::Bind(&VideoTrackRecorderTest::OnEncodedVideo,
base::Unretained(this)),
0 /* bits_per_second */));
@@ -163,7 +166,7 @@ TEST_P(VideoTrackRecorderTest, VideoEncoding) {
run_loop.Run();
- const size_t kEncodedSizeThreshold = 18;
+ const size_t kEncodedSizeThreshold = 14;
EXPECT_GE(first_frame_encoded_data.size(), kEncodedSizeThreshold);
EXPECT_GE(second_frame_encoded_data.size(), kEncodedSizeThreshold);
EXPECT_GE(third_frame_encoded_data.size(), kEncodedSizeThreshold);
@@ -173,6 +176,6 @@ TEST_P(VideoTrackRecorderTest, VideoEncoding) {
INSTANTIATE_TEST_CASE_P(,
VideoTrackRecorderTest,
- ValuesIn(kTrackRecorderTestUseVp9OrNot));
+ ValuesIn(kTrackRecorderTestCodec));
} // namespace content
« no previous file with comments | « content/renderer/media/video_track_recorder.cc ('k') | media/muxers/webm_muxer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698