Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 18861008: Revert 210434 "Revert 210433 "Revert 210423 "base: Make Sequence..." (Closed)

Created:
7 years, 5 months ago by awong
Modified:
7 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 210434 "Revert 210433 "Revert 210423 "base: Make Sequence..." The SequencedWorkerPool change broke CrOs (daisy) builder due to unused variable: threading/sequenced_worker_pool.cc:682:13: error: variable 'shutdown_wait_begin' reverting until that is fixed. > Revert 210433 "Revert 210423 "base: Make SequencedWorkerPool iss..." > > Undoing speculative revert. Still failed after revert. > > > Revert 210423 "base: Make SequencedWorkerPool issue globally uni..." > > > > Speculative revert for failing PageCyclerTest.FailProvisionalLoads on > > linux_clang. > > > > > base: Make SequencedWorkerPool issue globally unique SequenceTokens. > > > > > > SequencedWorkerPool currently issues SequenceTokens out of an internal member counter. This means that two different SequencedWorkerPool instances can issue identical SequenceTokens, which mucks up any attempt to distinguish sequences using only SequenceTokens. > > > > > > This change makes the SequenceTokens issued from an StaticAtomicSequenceNumber, which is globally shared amongst all SequencedWorkerPools. > > > > > > This change also makes the SequencedWorkerPool included in the nacl_untrusted builds, as it is needed for SequenceChecker and WeakPtr to work correctly. It previously was excluded because it used base/metrics. I've #ifdefed the base/metrics usage out for nacl. > > > > > > This issue is a spinoff and pre-requisite of issue 18501008: Make WeakPtr use SequenceChecker instead of ThreadChecker. > > > > > > R=akalin,darin > > > BUG=165590 > > > > > > Review URL: https://chromiumcodereview.appspot.com/18650006 > > > > TBR=tommycli@chromium.org > > > > Review URL: https://codereview.chromium.org/18271011 > > TBR=scottmg@chromium.org > > Review URL: https://codereview.chromium.org/18242008 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -51 lines) Patch
M trunk/src/base/base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/base/threading/sequenced_worker_pool.h View 3 chunks +1 line, -11 lines 0 comments Download
M trunk/src/base/threading/sequenced_worker_pool.cc View 12 chunks +9 lines, -40 lines 0 comments Download
M trunk/src/base/threading/sequenced_worker_pool_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
7 years, 5 months ago (2013-07-08 23:49:45 UTC) #1
awong
7 years, 5 months ago (2013-07-08 23:50:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r210462.

Powered by Google App Engine
This is Rietveld 408576698