Make canvas filters use the font size in effect when the filter is set

Make canvas filters use the font size in effect when the filter is set

This snapshots the current font when a new filter is set,
and uses the snapshotted font whenever the filter is rebuilt,
rather than using the current font. The filter is no longer
rebuilt for changes to the current font. This matches Firefox's
behavior.

BUG=601877
Committed: https://crrev.com/222eb4b80b8531ca616f78207033427d359c2879
Cr-Commit-Position: refs/heads/master@{#388099}

[ajuma, 2016-04-14 14:24:45]

Description was changed from

==========
Make canvas filters use the font size in effect when the filter is set

BUG=601877
==========

to

==========
Make canvas filters use the font size in effect when the filter is set

This snapshots the current font when a new filter is set,
and uses the snapshotted font whenever the filter is rebuilt,
rather than using the current font. The filter is no longer
rebuilt for changes to the current font. This matches Firefox's
behavior.

BUG=601877
==========

[ajuma, 2016-04-14 14:24:45]

ajuma@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-04-18 18:03:22]

lgtm with nit.

https://codereview.chromium.org/1886063002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1886063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:135:
void OffscreenCanvasRenderingContext2D::snapshotStateForFilter()
Nit: could put empty impl in header, like you did for PaintRenderingContext2D

[ajuma, 2016-04-18 21:32:44]

https://codereview.chromium.org/1886063002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1886063002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:135:
void OffscreenCanvasRenderingContext2D::snapshotStateForFilter()
On 2016/04/18 18:03:22, Justin Novosad wrote:
> Nit: could put empty impl in header, like you did for PaintRenderingContext2D

Done.

[ajuma, 2016-04-18 21:32:50]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-04-18 21:32:50]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1886063002/#ps40001
(title: "Address review comment")

[commit-bot: I haz the power, 2016-04-18 21:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886063002/40001

[commit-bot: I haz the power, 2016-04-18 21:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 21:36:12]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ajuma, 2016-04-18 21:54:08]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-04-18 21:54:08]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1886063002/#ps60001
(title: "Rebase again")

[commit-bot: I haz the power, 2016-04-18 21:54:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886063002/60001

[commit-bot: I haz the power, 2016-04-19 00:51:45]

Description was changed from

==========
Make canvas filters use the font size in effect when the filter is set

This snapshots the current font when a new filter is set,
and uses the snapshotted font whenever the filter is rebuilt,
rather than using the current font. The filter is no longer
rebuilt for changes to the current font. This matches Firefox's
behavior.

BUG=601877
==========

to

==========
Make canvas filters use the font size in effect when the filter is set

This snapshots the current font when a new filter is set,
and uses the snapshotted font whenever the filter is rebuilt,
rather than using the current font. The filter is no longer
rebuilt for changes to the current font. This matches Firefox's
behavior.

BUG=601877
==========

[commit-bot: I haz the power, 2016-04-19 00:51:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-19 00:52:48]

Description was changed from

==========
Make canvas filters use the font size in effect when the filter is set

This snapshots the current font when a new filter is set,
and uses the snapshotted font whenever the filter is rebuilt,
rather than using the current font. The filter is no longer
rebuilt for changes to the current font. This matches Firefox's
behavior.

BUG=601877
==========

to

==========
Make canvas filters use the font size in effect when the filter is set

This snapshots the current font when a new filter is set,
and uses the snapshotted font whenever the filter is rebuilt,
rather than using the current font. The filter is no longer
rebuilt for changes to the current font. This matches Firefox's
behavior.

BUG=601877

Committed: https://crrev.com/222eb4b80b8531ca616f78207033427d359c2879
Cr-Commit-Position: refs/heads/master@{#388099}
==========

[commit-bot: I haz the power, 2016-04-19 00:52:50]

Patchset 4 (id:??) landed as
https://crrev.com/222eb4b80b8531ca616f78207033427d359c2879
Cr-Commit-Position: refs/heads/master@{#388099}