Issue 18860007: Move InitializeICU() to the V8 API and use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18860007: Move InitializeICU() to the V8 API and use it. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Move InitializeICU() to the V8 API and use it. I can't get rid of the enable_i18n flag yet, as we need to be able to turn off all extensions for creating the snapshot. BUG=v8:2745 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15618

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -22 lines)			Patch
M	include/v8.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	samples/lineprocessor.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	samples/process.cc	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	samples/samples.gyp	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	samples/shell.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/d8.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	src/d8.gyp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/icu_util.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/icu_util.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/mksnapshot.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

7 years, 5 months ago (2013-07-11 09:59:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15618 (presubmit successful).