Issue 18860003: Use JSONEncoder to escape JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18860003: Use JSONEncoder to escape JSON strings. (Closed)

Created:
7 years, 5 months ago by Jói

Modified:
7 years, 5 months ago

Reviewers:
alexeypa (please no reviews)

CC:
grit-developer_googlegroups.com

Base URL:
https://grit-i18n.googlecode.com/svn/trunk

Visibility:
Public.

Use JSONEncoder to escape JSON strings. This CL fixes escaping of '\n' and unicode characters. BUG=grit-i18n:20 Landing for alexeypa@chromium.org, patch from issue 18301005. Committed: https://code.google.com/p/grit-i18n/source/detail?r=129

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	grit/format/chrome_messages_json.py	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	grit/format/chrome_messages_json_unittest.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Jói

Committed patchset #1 manually as r129 (presubmit successful).

7 years, 5 months ago (2013-07-08 16:51:22 UTC) #2

Message was sent while issue was closed.

lgtm