Issue 1885993003: [Sync] Fix a subtle use-after-free in Attachments.

Issue 1885993003: [Sync] Fix a subtle use-after-free in Attachments. (Closed)

Created:
4 years, 8 months ago by maxbogue

Modified:
4 years, 8 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, glider+watch_chromium.org, sync-reviews_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Sync] Fix a subtle use-after-free in Attachments. See the bug for further explanation. BUG=603275 Committed: https://crrev.com/b692133db89e42a7f43aa6a916e214223986b814 Cr-Commit-Position: refs/heads/master@{#387373}

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -14 lines)			Patch
	M	sync/internal_api/attachments/attachment_downloader_impl.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885993003/1

4 years, 8 months ago (2016-04-14 18:25:35 UTC) #5

commit-bot: I haz the power

4 years, 8 months ago (2016-04-14 18:34:37 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b692133db89e42a7f43aa6a916e214223986b814
Cr-Commit-Position: refs/heads/master@{#387373}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages