Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).

BUG=595089
Committed: https://crrev.com/eebc689061ed11598010112c5e47cce7edfa80ac
Cr-Commit-Position: refs/heads/master@{#387336}

[Łukasz Anforowicz, 2016-04-13 20:00:17]

Description was changed from

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Main changes
============

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).


Secondary changes
=================

Changing which BlinkTestRunner is used, exposes a problem where
BlinkTestRunner::SetFocus tries to track a global focus, but does this
using an instance-specific field of BlinkTestRunner.  This CL makes
changes to BlinkTestRunner::SetFocus to make sure focus tracking stays
global.  Layout tests that fail without the secondary change:
- scrollbars/custom-scrollbar-inactive-pseudo.html
- http/tests/notifications/click-window-focus-document.html


BUG=582525, 595089
==========

to

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).


BUG=582525, 595089
==========

[Łukasz Anforowicz, 2016-04-13 20:02:16]

Description was changed from

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).


BUG=582525, 595089
==========

to

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).


BUG=595089
==========

[Łukasz Anforowicz, 2016-04-13 20:02:23]

Description was changed from

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).


BUG=595089
==========

to

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).

BUG=595089
==========

[Łukasz Anforowicz, 2016-04-13 21:24:25]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-13 21:24:26]

jochen@, could you please take a look?

[jochen (gone - plz use gerrit), 2016-04-14 13:30:59]

lgtm

[Łukasz Anforowicz, 2016-04-14 13:50:23]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 13:51:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885993002/20001

[commit-bot: I haz the power, 2016-04-14 14:27:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 14:27:40]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-04-14 16:30:39]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-14 16:30:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885993002/20001

[commit-bot: I haz the power, 2016-04-14 16:36:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 16:37:50]

Description was changed from

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).

BUG=595089
==========

to

==========
Use correct WebTestDelegate from WebViewTestClient and WebTestProxyBase.

Before this CL:
- WebViewTestClient would use a WebTestDelegate from the (effectively
  global) TestInterfaces object.
- WebTestProxyBase would use a WebTestDelegate from the global
  LayoutTestRenderProcessObserver singleton.

This WebTestDelegate (aka BlinkTestRunner) might or might not be
associated with the specific view related to the given WebView /
RenderView / WebViewTestClient / WebTestProxyBase.  This in turn could
lead to UaF (no repro at ToT - this would be trigerred after some other
OOPIF-related changes that have not landed yet).

This CL modifies WebTestProxyCreated function in
layout_test_content_renderer_client.cc to make sure the right
BlinkTestRunner is passed to the WebTestProxyBase.  Other changes make
sure that WebViewTestClient uses BlinkTestRunner from the associated
WebTestProxyBase (rather than using one handed over from
WebTestInterfaces).

BUG=595089

Committed: https://crrev.com/eebc689061ed11598010112c5e47cce7edfa80ac
Cr-Commit-Position: refs/heads/master@{#387336}
==========

[commit-bot: I haz the power, 2016-04-14 16:37:52]

Patchset 2 (id:??) landed as
https://crrev.com/eebc689061ed11598010112c5e47cce7edfa80ac
Cr-Commit-Position: refs/heads/master@{#387336}