xfa/fxfa/app/xfa_ffwidget.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1032)

My Issues | Starred Open | Closed | All

Unified Diff: xfa/fxfa/app/xfa_ffwidget.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Win error #2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp ('K') | « xfa/fxfa/app/xfa_ffdoc.cpp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/fxfa/app/xfa_ffwidget.cpp

diff --git a/xfa/fxfa/app/xfa_ffwidget.cpp b/xfa/fxfa/app/xfa_ffwidget.cpp

index f2c8ad79a0d8b2c9e8da3e337750852e4402c47a..037e6560deb01e758bf56304398cae897f3f1908 100644

--- a/xfa/fxfa/app/xfa_ffwidget.cpp

+++ b/xfa/fxfa/app/xfa_ffwidget.cpp

@@ -991,7 +991,7 @@ CFX_DIBitmap* XFA_LoadImageData(CXFA_FFDoc* pDoc,

CFX_ByteString bsData = wsImage.UTF8Encode();

int32_t iLength = bsData.GetLength();

pImageBuffer = FX_Alloc(uint8_t, iLength);

- int32_t iRead = XFA_Base64Decode((const FX_CHAR*)bsData, pImageBuffer);

+ int32_t iRead = XFA_Base64Decode(bsData.c_str(), pImageBuffer);

if (iRead > 0) {

pImageFileRead = FX_CreateMemoryStream(pImageBuffer, iRead);

}

« fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp ('K') | « xfa/fxfa/app/xfa_ffdoc.cpp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698