xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Win error #2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp

diff --git a/xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp b/xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp

index 21ccafc20c7573e4be6f1dd4e880e683cd3a178d..943384d55cb8a5a0e90c4bca6d1f439b09afb6f3 100644

--- a/xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp

+++ b/xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp

@@ -70,9 +70,9 @@ int32_t CBC_OnedUPCAWriter::CalcChecksum(const CFX_ByteString& contents) {

int32_t j = 1;

for (int32_t i = contents.GetLength() - 1; i >= 0; i--) {

if (j % 2) {

- odd += FXSYS_atoi(contents.Mid(i, 1));

+ odd += FXSYS_atoi(contents.Mid(i, 1).c_str());

} else {

- even += FXSYS_atoi(contents.Mid(i, 1));

+ even += FXSYS_atoi(contents.Mid(i, 1).c_str());

}

j++;

}