core/fxcrt/include/fx_string.h - Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1885973002: Remove implicit cast from CFX_ByteString to (const char*). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/include/fx_string.h

diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h

index ef0dfee6fb9b100e440bef0080cbb0e211a60c0a..4b73551573f43edca7d0cdd1e6b962015b10aaac 100644

--- a/core/fxcrt/include/fx_string.h

+++ b/core/fxcrt/include/fx_string.h

@@ -170,9 +170,6 @@ class CFX_ByteString {

// Note: Any subsequent modification of |this| will invalidate the result.

const FX_CHAR* c_str() const { return m_pData ? m_pData->m_String : ""; }

- // Implicit conversion to C-style string -- deprecated.

Tom Sepez 2016/04/13 18:26:38 note: this is the one change, everything else foll

- operator const FX_CHAR*() const { return m_pData ? m_pData->m_String : ""; }

// Explicit conversion to uint8_t*.

// Note: Any subsequent modification of |this| will invalidate the result.

const uint8_t* raw_str() const {

« no previous file with comments | « core/fxcrt/fx_basic_util.cpp ('k') | core/fxge/ge/fx_ge_fontmap.cpp » ('j') | no next file with comments »