Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: tests/git_cl_test.py

Issue 1885963002: Followup for git cl set-commit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 295d1a0fb62f7f073a6099d8e4c9a8818e884759..80021904d7cfb9432e4dd462185553e5069ed240 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -1353,6 +1353,9 @@ class TestGitCl(TestCase):
((['SetReview', 'chromium-review.googlesource.com', 123,
{'Commit-Queue': 1}],), ''),
]
+ # TODO(tandrii): consider testing just set-commit and set-commit --clear,
+ # but without copy-pasting tons of expectations, as modifying them later is
+ # super tedious.
self.assertEqual(0, git_cl.main(['set-commit', '-d']))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698