base/message_loop/incoming_task_queue.cc - Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/incoming_task_queue.cc

Issue 1885933002: Ensure that DLOG(FATAL) also asserts in release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment with installer fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/message_loop/incoming_task_queue.cc

diff --git a/base/message_loop/incoming_task_queue.cc b/base/message_loop/incoming_task_queue.cc

index 05bb28891c9b922f2d81e6494c77ba934372a101..ebecc1ba54ce35df2cfef606eca13c8ed4062569 100644

--- a/base/message_loop/incoming_task_queue.cc

+++ b/base/message_loop/incoming_task_queue.cc

@@ -17,7 +17,7 @@ namespace internal {

namespace {

-#ifndef NDEBUG

+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

// Delays larger than this are often bogus, and a warning should be emitted in

// debug builds to warn developers. http://crbug.com/450045

const int kTaskDelayWarningThresholdInSeconds =

« no previous file with comments | « base/logging_unittest.cc ('k') | base/metrics/persistent_histogram_allocator.cc » ('j') | no next file with comments »