Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1885903003: [Mac] Increase infobar height under Material Design. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Increase infobar height under Material Design. Under Material Design the infobar height has increased slightly. R=avi@chromium.org BUG=593664 Committed: https://crrev.com/7fada7682f1b88e2615ef3261ed86e0b0a5f2765 Cr-Commit-Position: refs/heads/master@{#387146}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 2 chunks +13 lines, -0 lines 1 comment Download
M chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shrike
PTAL
4 years, 8 months ago (2016-04-13 21:15:43 UTC) #1
Avi (use Gerrit)
lgtm https://codereview.chromium.org/1885903003/diff/1/chrome/browser/ui/cocoa/infobars/infobar_controller.mm File chrome/browser/ui/cocoa/infobars/infobar_controller.mm (right): https://codereview.chromium.org/1885903003/diff/1/chrome/browser/ui/cocoa/infobars/infobar_controller.mm#newcode86 chrome/browser/ui/cocoa/infobars/infobar_controller.mm:86: } Joy... It's a race now between the ...
4 years, 8 months ago (2016-04-13 21:35:00 UTC) #2
shrike
On 2016/04/13 21:35:00, Avi wrote: > lgtm > > https://codereview.chromium.org/1885903003/diff/1/chrome/browser/ui/cocoa/infobars/infobar_controller.mm > File chrome/browser/ui/cocoa/infobars/infobar_controller.mm (right): > ...
4 years, 8 months ago (2016-04-13 22:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885903003/1
4 years, 8 months ago (2016-04-13 22:40:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 23:35:12 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:36:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fada7682f1b88e2615ef3261ed86e0b0a5f2765
Cr-Commit-Position: refs/heads/master@{#387146}

Powered by Google App Engine
This is Rietveld 408576698