Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.h

Issue 1885903002: Revert of Make lost context and error message callbacks on GpuControl go to client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/in_process_command_buffer.h
diff --git a/gpu/command_buffer/service/in_process_command_buffer.h b/gpu/command_buffer/service/in_process_command_buffer.h
index c0221dd0288afdb824547fa7f08f78ec76d244b1..731c4868f54db8cffe571b1cd3c96f30a43a4037 100644
--- a/gpu/command_buffer/service/in_process_command_buffer.h
+++ b/gpu/command_buffer/service/in_process_command_buffer.h
@@ -19,7 +19,6 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
-#include "base/single_thread_task_runner.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread.h"
@@ -93,6 +92,7 @@
const gfx::Size& size,
const std::vector<int32_t>& attribs,
gfx::GpuPreference gpu_preference,
+ const base::Closure& context_lost_callback,
InProcessCommandBuffer* share_group,
GpuMemoryBufferManager* gpu_memory_buffer_manager,
ImageFactory* image_factory);
@@ -113,8 +113,6 @@
gpu::error::Error GetLastError() override;
// GpuControl implementation:
- // NOTE: The GpuControlClient will be called on the client thread.
- void SetGpuControlClient(GpuControlClient*) override;
gpu::Capabilities GetCapabilities() override;
int32_t CreateImage(ClientBuffer buffer,
size_t width,
@@ -241,18 +239,17 @@
void DestroyImageOnGpuThread(int32_t id);
void SetGetBufferOnGpuThread(int32_t shm_id, base::WaitableEvent* completion);
- // Callbacks on the gpu thread.
- void OnContextLostOnGpuThread();
- void PumpCommandsOnGpuThread();
- void PerformDelayedWorkOnGpuThread();
- // Callback implementations on the client thread.
+ // Callbacks:
void OnContextLost();
+ bool GetBufferChanged(int32_t transfer_buffer_id);
+ void PumpCommands();
+ void PerformDelayedWork();
const CommandBufferId command_buffer_id_;
// Members accessed on the gpu thread (possibly with the exception of
// creation):
- scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_;
+ bool context_lost_;
scoped_refptr<TransferBufferManagerInterface> transfer_buffer_manager_;
scoped_ptr<CommandExecutor> executor_;
scoped_ptr<gles2::GLES2Decoder> decoder_;
@@ -261,15 +258,10 @@
scoped_refptr<SyncPointOrderData> sync_point_order_data_;
scoped_ptr<SyncPointClient> sync_point_client_;
base::Closure context_lost_callback_;
- // Used to throttle PerformDelayedWorkOnGpuThread.
- bool delayed_work_pending_;
+ bool delayed_work_pending_; // Used to throttle PerformDelayedWork.
ImageFactory* image_factory_;
// Members accessed on the client thread:
- GpuControlClient* gpu_control_client_;
-#if DCHECK_IS_ON()
- bool context_lost_;
-#endif
State last_state_;
int32_t last_put_offset_;
gpu::Capabilities capabilities_;
@@ -296,9 +288,7 @@
// the client thread.
scoped_ptr<base::SequenceChecker> sequence_checker_;
- base::WeakPtr<InProcessCommandBuffer> client_thread_weak_ptr_;
base::WeakPtr<InProcessCommandBuffer> gpu_thread_weak_ptr_;
- base::WeakPtrFactory<InProcessCommandBuffer> client_thread_weak_ptr_factory_;
base::WeakPtrFactory<InProcessCommandBuffer> gpu_thread_weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(InProcessCommandBuffer);
« no previous file with comments | « gpu/command_buffer/client/gpu_control_client.h ('k') | gpu/command_buffer/service/in_process_command_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698