Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3590)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 18859004: views impl: hide top infobar arrow when omnibox popup shows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: correct previous comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index 5f9e6c65c65c3b64a8fc7c915fc077db6b5ef8af..a92a50183a60d791ad90fe123b24957512b6b72c 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -17,6 +17,7 @@
#include "chrome/browser/infobars/infobar_container.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/omnibox/omnibox_popup_model_observer.h"
#include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
#include "chrome/browser/ui/views/frame/browser_frame.h"
#include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
@@ -100,7 +101,8 @@ class BrowserView : public BrowserWindow,
public InfoBarContainer::Delegate,
public views::SingleSplitViewListener,
public gfx::SysColorChangeListener,
- public LoadCompleteListener::Delegate {
+ public LoadCompleteListener::Delegate,
+ public OmniboxPopupModelObserver {
public:
// The browser view's class name.
static const char kViewClassName[];
@@ -455,6 +457,9 @@ class BrowserView : public BrowserWindow,
// Overridden from ui::AcceleratorTarget:
virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE;
+ // OmniboxPopupModelObserver overrides
+ virtual void OnOmniboxPopupShownOrHidden() OVERRIDE;
+
// Testing interface:
views::SingleSplitView* GetContentsSplitForTest() { return contents_split_; }
ContentsContainer* GetContentsContainerForTest() {
@@ -601,7 +606,7 @@ class BrowserView : public BrowserWindow,
// |contents_container_|.
void MakeOverlayContentsActiveContents();
- // Return the max top arrow height for infobar.
+ // Returns the max top arrow height for infobar.
int GetMaxTopInfoBarArrowHeight();
// Last focused view that issued a tab traversal.
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_popup_model_observer.h ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698