chrome/browser/ui/omnibox/omnibox_popup_model_observer.h - Issue 18859004: views impl: hide top infobar arrow when omnibox popup shows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/omnibox/omnibox_popup_model_observer.h

Issue 18859004: views impl: hide top infobar arrow when omnibox popup shows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add missing file Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_POPUP_MODEL_OBSERVER_H_

	6 #define CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_POPUP_MODEL_OBSERVER_H_

	7

	8 // This class defines the observer interface for the \|OmniboxPopupModel\|.
	Peter Kasting 2013/07/09 17:35:20 This comment restates the obvious. Instead, say w This comment restates the obvious. Instead, say why people might want this functionality. kuan 2013/07/09 17:48:47 Done. Show quoted text On 2013/07/09 17:35:20, Peter Kasting wrote: > This comment restates the obvious. Instead, say why people might want this > functionality. Done.
	9 class OmniboxPopupModelObserver {

	10 public:

	11 // Informs observers that omnibox popup has been shown or hidden.

	12 virtual void OnOmniboxPopupShownOrHidden() = 0;

	13

	14 protected:

	15 virtual ~OmniboxPopupModelObserver() {}
	Peter Kasting 2013/07/09 17:35:20 Is this necessary? I'd just omit this entirely. Is this necessary? I'd just omit this entirely. kuan 2013/07/09 17:48:47 Done. Show quoted text On 2013/07/09 17:35:20, Peter Kasting wrote: > Is this necessary? I'd just omit this entirely. Done.
	16 };

	17

	18 #endif // CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_POPUP_MODEL_OBSERVER_H_

OLD	NEW