Chromium Code Reviews| Index: git_cl.py |
| diff --git a/git_cl.py b/git_cl.py |
| index c8153dbec35573f0fae698244d94964e9e2ce22c..36a19293f2117a16f083c004506f281fde47b58e 100755 |
| --- a/git_cl.py |
| +++ b/git_cl.py |
| @@ -2391,35 +2391,26 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): |
| print('WARNING: underscores in title will be converted to spaces.') |
| refspec_opts.append('m=' + options.title.replace(' ', '_')) |
| - receive_options = [] |
| cc = self.GetCCList().split(',') |
|
Michael Achenbach
2016/04/13 12:43:04
Can there be spaces after the comma by any chance?
tandrii(chromium)
2016/04/13 12:53:14
good point, stripped.
|
| if options.cc: |
| cc.extend(options.cc) |
| cc = filter(None, cc) |
| if cc: |
| - receive_options += ['--cc=' + email for email in cc] |
| + refspec_opts.extend('cc=' + email for email in cc) |
| + |
| if change_desc.get_reviewers(): |
| - receive_options.extend( |
| - '--reviewer=' + email for email in change_desc.get_reviewers()) |
| + refspec_opts.extend('r=' + email for email in change_desc.get_reviewers()) |
| - git_command = ['git', 'push'] |
| - if receive_options: |
| - # TODO(tandrii): clean this up in follow up. This doesn't work, as it gets |
| - # totally ignored by Gerrit. |
| - git_command.append('--receive-pack=git receive-pack %s' % |
| - ' '.join(receive_options)) |
| refspec_suffix = '' |
| if refspec_opts: |
| refspec_suffix = '%' + ','.join(refspec_opts) |
| assert ' ' not in refspec_suffix, ( |
| 'spaces not allowed in refspec: "%s"' % refspec_suffix) |
| - |
| refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix) |
| - git_command += [gerrit_remote, refspec] |
| push_stdout = gclient_utils.CheckCallAndFilter( |
| - git_command, |
| + ['git', 'push', gerrit_remote, refspec], |
| print_stdout=True, |
| # Flush after every line: useful for seeing progress when running as |
| # recipe. |