chrome/browser/permissions/permission_manager.cc - Issue 1885823002: Fix bug: MIDI causes crash on onContentSettingChanged()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_manager.cc

Issue 1885823002: Fix bug: MIDI causes crash on onContentSettingChanged() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/permissions/permission_manager.cc

diff --git a/chrome/browser/permissions/permission_manager.cc b/chrome/browser/permissions/permission_manager.cc

index 951966c92e750f67c3ad04e43e095a7529ae6967..d718eed5d7718496e7870d0f98485dbcb074c1f2 100644

--- a/chrome/browser/permissions/permission_manager.cc

+++ b/chrome/browser/permissions/permission_manager.cc

@@ -398,6 +398,9 @@ void PermissionManager::OnContentSettingChanged(

for (SubscriptionsMap::iterator iter(&subscriptions_);

!iter.IsAtEnd(); iter.Advance()) {

Subscription* subscription = iter.GetCurrentValue();

+ if (IsConstantPermission(subscription->permission)) {

+ continue;

+ }

raymes 2016/04/13 04:11:36 nit: no {}

if (PermissionTypeToContentSetting(subscription->permission) !=

content_type) {

continue;

« no previous file with comments | « no previous file | no next file » | no next file with comments »