Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 18858003: MIPS: Bugfix: The general array constructor stub did not handle the case properly when it is called… (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Bugfix: The general array constructor stub did not handle the case properly when it is called with a function pointer in the type cell, instead assuming that an AllocationSite object should be present. Port r15555 (262c081) Original commit message: The case where this can happen is if the cell is uninitialized, then the first constructor call made is to the Array function of a different context. In that case, we'll store the function pointer in the cell, and then go ahead and call the array constructor stub too. The bug is fixed by checking for the AllocationSite object map. If not found, the constructor stub goes forward with a default ElementsKind, just as in several other cases. A test in allocation-site-info.js was beefed up to make sure the state chain described above is traversed. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 5 months ago (2013-07-08 17:40:33 UTC) #1
kisg
LGTM
7 years, 5 months ago (2013-07-08 17:50:11 UTC) #2
palfia
7 years, 5 months ago (2013-07-08 17:58:44 UTC) #3
Committed as r15562.

Powered by Google App Engine
This is Rietveld 408576698