[Autofill] Don't fill expiration date of expired credit cards.

Do not fill the expiration date of expired credit cards in Autofill.

Moved the GenerateSelectFieldWithOptions method from autofill_field_unittest.cc to CreateTestSelectField in autofill_test_util.cc

BUG=602429
Committed: https://crrev.com/3cf9514720966c9b1cd77c7376c6670342ae97bf
Cr-Commit-Position: refs/heads/master@{#387082}

[sebsg, 2016-04-13 00:16:13]

Description was changed from

==========
[Autofill] Don't fill expiration date of expired credit cards.

BUG=602429
==========

to

==========
Do not fill the expiration date of expired credit cards in Autofill.

BUG=602429
==========

[sebsg, 2016-04-13 00:33:32]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-04-13 00:53:22]

Patchset #1 (id:20001) has been deleted

[sebsg, 2016-04-13 01:17:59]

Patchset #1 (id:40001) has been deleted

[sebsg, 2016-04-13 01:21:21]

Description was changed from

==========
Do not fill the expiration date of expired credit cards in Autofill.

BUG=602429
==========

to

==========
Do not fill the expiration date of expired credit cards in Autofill.

Moved the GenerateSelectFieldWithOptions method from autofill_field_unittest.cc
to CreateTestSelectField in autofill_test_util.cc

BUG=602429
==========

[sebsg, 2016-04-13 01:21:21]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2016-04-13 01:57:38]

Patchset #1 (id:60001) has been deleted

[sebsg, 2016-04-13 01:58:07]

Hi Math could you please take a look?

Thanks!

[Mathieu, 2016-04-13 18:40:38]

lgtm, thanks!

https://codereview.chromium.org/1885773002/diff/80001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/1885773002/diff/80001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:195: // Returns whether the
credit card is expired based on |time|.
rename |time| to |now| or |current_time|?

[sebsg, 2016-04-13 20:16:32]

Thanks for the review!

https://codereview.chromium.org/1885773002/diff/80001/components/autofill/cor...
File components/autofill/core/browser/credit_card.h (right):

https://codereview.chromium.org/1885773002/diff/80001/components/autofill/cor...
components/autofill/core/browser/credit_card.h:195: // Returns whether the
credit card is expired based on |time|.
On 2016/04/13 18:40:37, Mathieu Perreault wrote:
> rename |time| to |now| or |current_time|?

Done.

[sebsg, 2016-04-13 20:16:37]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-04-13 20:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1885773002/#ps100001
(title: "Nit")

[commit-bot: I haz the power, 2016-04-13 20:16:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885773002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885773002/100001

[commit-bot: I haz the power, 2016-04-13 20:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:31:02]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[sebsg, 2016-04-13 20:44:12]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:44:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885773002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885773002/100001

[commit-bot: I haz the power, 2016-04-13 21:03:02]

Description was changed from

==========
Do not fill the expiration date of expired credit cards in Autofill.

Moved the GenerateSelectFieldWithOptions method from autofill_field_unittest.cc
to CreateTestSelectField in autofill_test_util.cc

BUG=602429
==========

to

==========
Do not fill the expiration date of expired credit cards in Autofill.

Moved the GenerateSelectFieldWithOptions method from autofill_field_unittest.cc
to CreateTestSelectField in autofill_test_util.cc

BUG=602429
==========

[commit-bot: I haz the power, 2016-04-13 21:03:04]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-04-13 21:03:49]

Description was changed from

==========
Do not fill the expiration date of expired credit cards in Autofill.

Moved the GenerateSelectFieldWithOptions method from autofill_field_unittest.cc
to CreateTestSelectField in autofill_test_util.cc

BUG=602429
==========

to

==========
Do not fill the expiration date of expired credit cards in Autofill.

Moved the GenerateSelectFieldWithOptions method from autofill_field_unittest.cc
to CreateTestSelectField in autofill_test_util.cc

BUG=602429

Committed: https://crrev.com/3cf9514720966c9b1cd77c7376c6670342ae97bf
Cr-Commit-Position: refs/heads/master@{#387082}
==========

[commit-bot: I haz the power, 2016-04-13 21:03:50]

Patchset 2 (id:??) landed as
https://crrev.com/3cf9514720966c9b1cd77c7376c6670342ae97bf
Cr-Commit-Position: refs/heads/master@{#387082}