Major part of CrasAudioClientUnittest

Major part of CrasAudioClientUnittest

Currently done:
(1) signal monitoring test
OutputMuteChanged, InputMuteChanged, NodesChanged, ActiveOutputNodeChanged, ActiveInputNodeChanged.

(2) client API test
GetVolumeState, GetNodes, SetGlobalOutputChannelRemix.

Remaining tests are pretty much the same as the above. Will do it on a separate CL.

Existing warnings:
each test case has the following Warning:
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: AssertOnOriginThread()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

BUG=598800
Committed: https://crrev.com/c9b2849b11b322f770d1f3aaed2769fdfdcf545c
Cr-Commit-Position: refs/heads/master@{#387372}

[Qiang(Joe) Xu, 2016-04-13 19:01:27]

Description was changed from

==========
Major part of CrasAudioClientUnittest

BUG=598800
==========

to

==========
Major part of CrasAudioClientUnittest

Currently done:
(1) signal monitoring test
OutputMuteChanged, InputMuteChanged, NodesChanged, ActiveOutputNodeChanged,
ActiveInputNodeChanged.

(2) client API test
GetVolumeState, GetNodes, SetGlobalOutputChannelRemix.

Remaining tests are pretty much the same as the above. Will do it on a separate
CL.

Existing warnings:
each test case has the following Warning:
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: AssertOnOriginThread()
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.


BUG=598800
==========

[Qiang(Joe) Xu, 2016-04-13 19:03:10]

warx@chromium.org changed reviewers:
+ jennyz@chromium.org

[jennyz, 2016-04-14 00:12:31]

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
File chromeos/dbus/cras_audio_client_unittest.cc (right):

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
chromeos/dbus/cras_audio_client_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2012 -> 2016
remove (c): This is deprecated style.

http://www.chromium.org/developers/coding-style#TOC-File-headers

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
chromeos/dbus/cras_audio_client_unittest.cc:545: TEST_F(CrasAudioClientTest,
GetVolumeState) {
GetVolumeState isn't not really useful, we don't need to test it. Actually, we
should remove it from the API, since no one is using it, we never tested it,
cras team may not maintain it either. But that can't be done in a separate cl.

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
chromeos/dbus/cras_audio_client_unittest.cc:585: // response for
kInternalSpeaker
Can the code for adding a audio node be wrapped into a function, so that we
don't have to repeat the complete section of the code each time for adding
another node?

[Qiang(Joe) Xu, 2016-04-14 01:25:49]

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
File chromeos/dbus/cras_audio_client_unittest.cc (right):

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
chromeos/dbus/cras_audio_client_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2016/04/14 00:12:31, jennyz wrote:
> 2012 -> 2016
> remove (c): This is deprecated style.
> 
> http://www.chromium.org/developers/coding-style#TOC-File-headers

Done.

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
chromeos/dbus/cras_audio_client_unittest.cc:545: TEST_F(CrasAudioClientTest,
GetVolumeState) {
On 2016/04/14 00:12:31, jennyz wrote:
> GetVolumeState isn't not really useful, we don't need to test it. Actually, we
> should remove it from the API, since no one is using it, we never tested it,
> cras team may not maintain it either. But that can't be done in a separate cl.

done by removing related contents. I do see GetVolumeState is not called by
cras_audio_handler.

https://codereview.chromium.org/1885763004/diff/20001/chromeos/dbus/cras_audi...
chromeos/dbus/cras_audio_client_unittest.cc:585: // response for
kInternalSpeaker
On 2016/04/14 00:12:31, jennyz wrote:
> Can the code for adding a audio node be wrapped into a function, so that we
> don't have to repeat the complete section of the code each time for adding
> another node?

done by creating a func WriteNodesToResponse

[jennyz, 2016-04-14 17:36:58]

lgtm

[Qiang(Joe) Xu, 2016-04-14 17:50:23]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2016-04-14 17:50:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1885763004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1885763004/40001

[commit-bot: I haz the power, 2016-04-14 18:27:29]

Description was changed from

==========
Major part of CrasAudioClientUnittest

Currently done:
(1) signal monitoring test
OutputMuteChanged, InputMuteChanged, NodesChanged, ActiveOutputNodeChanged,
ActiveInputNodeChanged.

(2) client API test
GetVolumeState, GetNodes, SetGlobalOutputChannelRemix.

Remaining tests are pretty much the same as the above. Will do it on a separate
CL.

Existing warnings:
each test case has the following Warning:
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: AssertOnOriginThread()
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.


BUG=598800
==========

to

==========
Major part of CrasAudioClientUnittest

Currently done:
(1) signal monitoring test
OutputMuteChanged, InputMuteChanged, NodesChanged, ActiveOutputNodeChanged,
ActiveInputNodeChanged.

(2) client API test
GetVolumeState, GetNodes, SetGlobalOutputChannelRemix.

Remaining tests are pretty much the same as the above. Will do it on a separate
CL.

Existing warnings:
each test case has the following Warning:
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: AssertOnOriginThread()
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.


BUG=598800
==========

[commit-bot: I haz the power, 2016-04-14 18:27:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-14 18:28:58]

Description was changed from

==========
Major part of CrasAudioClientUnittest

Currently done:
(1) signal monitoring test
OutputMuteChanged, InputMuteChanged, NodesChanged, ActiveOutputNodeChanged,
ActiveInputNodeChanged.

(2) client API test
GetVolumeState, GetNodes, SetGlobalOutputChannelRemix.

Remaining tests are pretty much the same as the above. Will do it on a separate
CL.

Existing warnings:
each test case has the following Warning:
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: AssertOnOriginThread()
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.


BUG=598800
==========

to

==========
Major part of CrasAudioClientUnittest

Currently done:
(1) signal monitoring test
OutputMuteChanged, InputMuteChanged, NodesChanged, ActiveOutputNodeChanged,
ActiveInputNodeChanged.

(2) client API test
GetVolumeState, GetNodes, SetGlobalOutputChannelRemix.

Remaining tests are pretty much the same as the above. Will do it on a separate
CL.

Existing warnings:
each test case has the following Warning:
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: AssertOnOriginThread()
NOTE: You can safely ignore the above warning unless this call should not
happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean
to enforce the call.  See
http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for
details.

BUG=598800

Committed: https://crrev.com/c9b2849b11b322f770d1f3aaed2769fdfdcf545c
Cr-Commit-Position: refs/heads/master@{#387372}
==========

[commit-bot: I haz the power, 2016-04-14 18:28:59]

Patchset 3 (id:??) landed as
https://crrev.com/c9b2849b11b322f770d1f3aaed2769fdfdcf545c
Cr-Commit-Position: refs/heads/master@{#387372}