Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1885733002: Revert of Log a non-crash dump for 10% of Spitzer pipeline decode failures. (Closed)

Created:
4 years, 8 months ago by DaleCurtis
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Log a non-crash dump for 10% of Spitzer pipeline decode failures. (patchset #1 id:1 of https://codereview.chromium.org/1808473002/ ) Reason for revert: Should have been reverted before M-51 branch, but forgot. Original issue's description: > Log a non-crash dump for 10% of Spitzer pipeline decode failures. > > Spitzer is currently enabled as a 40% experiment on dev (soon on > beta as well), but we have abnormally high video-only decode > failure rates, so add some logging to try and track this down. > > ~10% of the time, this change will log the 'subresource_url' crash > key as a non-crash dump when a decode error is encountered on > Android where Spitzer is enabled. > > This will allow us to investigate and triage these crashes. We're > already logging this key for normal crash dumps during DoLoad(). > > This is a temporary change which will be removed shortly after > landing once any issues are identified. > > BUG=595076 > TEST=none > > Committed: https://crrev.com/6e3901e3f6240d8660cb039fdcbb1dd6f75121f6 > Cr-Commit-Position: refs/heads/master@{#381532} TBR=rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595076 Committed: https://crrev.com/a5db39dd84b2fe72eb3260c35759a733bfa3df70 Cr-Commit-Position: refs/heads/master@{#386879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M media/blink/webmediaplayer_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
DaleCurtis
Created Revert of Log a non-crash dump for 10% of Spitzer pipeline decode failures.
4 years, 8 months ago (2016-04-12 23:42:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885733002/1
4 years, 8 months ago (2016-04-12 23:42:32 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/49439)
4 years, 8 months ago (2016-04-12 23:58:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885733002/1
4 years, 8 months ago (2016-04-13 00:42:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 00:56:28 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 00:57:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5db39dd84b2fe72eb3260c35759a733bfa3df70
Cr-Commit-Position: refs/heads/master@{#386879}

Powered by Google App Engine
This is Rietveld 408576698