Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188573002: GetHelp: Add missing permission "metricsPrivate" in manifest.json (Closed)

Created:
6 years, 9 months ago by cylee1
Modified:
6 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

GetHelp: Add missing permission "metricsPrivate" in manifest.json BUG=349863 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/genius_app/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
cnwan
lgtm
6 years, 9 months ago (2014-03-06 11:32:08 UTC) #1
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 9 months ago (2014-03-06 12:08:17 UTC) #2
cylee1
The CQ bit was unchecked by cylee@chromium.org
6 years, 9 months ago (2014-03-06 12:08:19 UTC) #3
Dmitry Polukhin
lgtm
6 years, 9 months ago (2014-03-06 16:45:14 UTC) #4
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 9 months ago (2014-03-06 17:34:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/188573002/1
6 years, 9 months ago (2014-03-06 17:35:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 17:40:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 17:40:16 UTC) #8
cylee1
The CQ bit was checked by cylee@chromium.org
6 years, 9 months ago (2014-03-06 19:22:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/188573002/1
6 years, 9 months ago (2014-03-06 19:30:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/188573002/1
6 years, 9 months ago (2014-03-06 21:02:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cylee@chromium.org/188573002/1
6 years, 9 months ago (2014-03-06 21:56:17 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 00:33:44 UTC) #13
Message was sent while issue was closed. 
Change committed as 255480

Powered by Google App Engine
This is Rietveld 408576698