Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1885683005: Add module suffix in .mojom files for components/arc (Closed)

Created:
4 years, 8 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tapted, cbentzel+watch_chromium.org, sadrul, Matt Giuca, viettrungluu+watch_chromium.org, tfarina, dcheng, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, oshima+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, davemoore+watch_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add module suffix in .mojom files for components/arc 'module arc;' --> 'module arc.mojom;' This way generated bindings will consistently live in a mojom sub-namespace and avoid collision with non-mojom types. This CL is for these .mojom files: components/arc/common/*.mojom BUG=588964 TBR=chrisha@chromium.org,piman@chromium.org Committed: https://crrev.com/890322916942fbdad77caea1ab9c6f1dc9eff459 Cr-Commit-Position: refs/heads/master@{#387823}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase only #

Patch Set 3 : Address comments from Luis #

Patch Set 4 : Rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -587 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_policy_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_policy_bridge.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_process_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_process_service.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/arc/gpu_arc_video_service_host.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 2 3 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/task_management/providers/arc/arc_process_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_context_menu_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 7 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 14 chunks +34 lines, -32 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/gpu/chrome_content_gpu_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_arc_video_service.h View 1 2 3 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/gpu/gpu_arc_video_service.cc View 1 2 3 13 chunks +31 lines, -27 lines 0 comments Download
M components/arc/arc_bridge_bootstrap.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/arc_bridge_bootstrap.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.h View 5 chunks +67 lines, -61 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 15 chunks +17 lines, -15 lines 0 comments Download
M components/arc/arc_bridge_service_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/audio/arc_audio_bridge.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.h View 1 3 chunks +27 lines, -27 lines 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.cc View 1 17 chunks +133 lines, -117 lines 0 comments Download
M components/arc/bluetooth/bluetooth_type_converters.h View 1 chunk +7 lines, -6 lines 0 comments Download
M components/arc/bluetooth/bluetooth_type_converters.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M components/arc/clipboard/arc_clipboard_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/clipboard/arc_clipboard_bridge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/arc/common/app.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/arc_bridge.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/audio.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/auth.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/bluetooth.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/clipboard.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/crash_collector.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/ime.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/input.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/intent_helper.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/net.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/notifications.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/policy.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/power.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/process.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/video.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/arc/common/video_accelerator.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/arc/crash_collector/arc_crash_collector_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/crash_collector/arc_crash_collector_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/ime/arc_ime_bridge_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/arc/ime/arc_ime_bridge_impl.cc View 5 chunks +37 lines, -35 lines 0 comments Download
M components/arc/input/arc_input_bridge.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/metrics/arc_metrics_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/metrics/arc_metrics_service.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/arc/net/arc_net_host_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/arc/net/arc_net_host_impl.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M components/arc/power/arc_power_bridge.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/arc/power/arc_power_bridge.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 5 chunks +23 lines, -19 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 4 chunks +22 lines, -20 lines 0 comments Download
M components/arc/test/fake_arc_bridge_bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/test/fake_arc_bridge_instance.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/arc/test/fake_arc_bridge_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/arc/test/fake_notifications_instance.h View 1 chunk +10 lines, -9 lines 0 comments Download
M components/arc/test/fake_notifications_instance.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/arc/notification/arc_notification_item.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/arc/notification/arc_notification_item.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M ui/arc/notification/arc_notification_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885683005/1
4 years, 8 months ago (2016-04-14 06:08:10 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 06:42:40 UTC) #4
leonhsl(Using Gerrit)
Would you PTAL at this? Thanks~ +lhchavez@ for components/arc, chrome/browser/chromeos/arc/ and overall +tsepez@ for components/arc/common/*.mojom ...
4 years, 8 months ago (2016-04-14 07:04:51 UTC) #6
Tom Sepez
RS LGTM based on inspection of .mojom and a few other samples.
4 years, 8 months ago (2016-04-14 15:59:21 UTC) #7
Luis Héctor Chávez
lgtm with nits. https://codereview.chromium.org/1885683005/diff/1/chrome/browser/memory/tab_manager_delegate_chromeos.cc File chrome/browser/memory/tab_manager_delegate_chromeos.cc (right): https://codereview.chromium.org/1885683005/diff/1/chrome/browser/memory/tab_manager_delegate_chromeos.cc#newcode141 chrome/browser/memory/tab_manager_delegate_chromeos.cc:141: VLOG(1) << "arc::mojom::ProcessInstance version < 2 ...
4 years, 8 months ago (2016-04-14 17:26:55 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885683005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885683005/20001
4 years, 8 months ago (2016-04-15 05:50:17 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885683005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885683005/40001
4 years, 8 months ago (2016-04-15 06:22:28 UTC) #12
leonhsl(Using Gerrit)
Would you PTAL for OWNERS review? Thanks~ +stevenjb@ for chrome/browser/ui/{app_list, ash} +chrisha@ for chrome/browser/memory +afakhry@ ...
4 years, 8 months ago (2016-04-15 06:33:25 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 07:07:25 UTC) #16
stevenjb
c/b/ui RS LGTM
4 years, 8 months ago (2016-04-15 15:43:57 UTC) #17
afakhry
On 2016/04/15 15:43:57, stevenjb wrote: > c/b/ui RS LGTM c/b/task_management lgtm.
4 years, 8 months ago (2016-04-15 16:34:51 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885683005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885683005/60001
4 years, 8 months ago (2016-04-16 13:32:28 UTC) #20
leonhsl(Using Gerrit)
Sorry I'd like to land this CL with TBR: chrisha@ for chrome/browser/memory piman@ for chrome/gpu ...
4 years, 8 months ago (2016-04-16 15:29:54 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885683005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885683005/60001
4 years, 8 months ago (2016-04-16 15:32:19 UTC) #27
chrisha
lgtm!
4 years, 8 months ago (2016-04-16 15:57:31 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-16 23:23:04 UTC) #29
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 23:24:34 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/890322916942fbdad77caea1ab9c6f1dc9eff459
Cr-Commit-Position: refs/heads/master@{#387823}

Powered by Google App Engine
This is Rietveld 408576698