Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 1885673004: Add a Utils class for the Physical Web (Closed)

Created:
4 years, 8 months ago by cco3
Modified:
4 years, 8 months ago
Reviewers:
nyquist, Yaron, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Utils class for the Physical Web Several methods that are used in the diagnostics page will be needed for UMA, so it's best to preemptively pull them out into a Utils class. BUG=594194 Committed: https://crrev.com/fda15c7a0c964e16dfed0c6e3f64c343e189b38d Cr-Commit-Position: refs/heads/master@{#387030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -70 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java View 7 chunks +31 lines, -70 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/physicalweb/Utils.java View 1 chunk +61 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
cco3
4 years, 8 months ago (2016-04-12 23:57:34 UTC) #2
mattreynolds
lgtm
4 years, 8 months ago (2016-04-13 00:00:31 UTC) #3
cco3
4 years, 8 months ago (2016-04-13 00:01:54 UTC) #5
cco3
This is safe part of a recently reverted commit. https://codereview.chromium.org/1878063002/
4 years, 8 months ago (2016-04-13 00:02:26 UTC) #6
Yaron
lgtm
4 years, 8 months ago (2016-04-13 15:51:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885673004/1
4 years, 8 months ago (2016-04-13 17:26:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 18:11:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:13:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fda15c7a0c964e16dfed0c6e3f64c343e189b38d
Cr-Commit-Position: refs/heads/master@{#387030}

Powered by Google App Engine
This is Rietveld 408576698