Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: blimp/engine/session/blimp_engine_session.cc

Issue 1885673003: Create and integrate a metrics service client into Blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean ups from initial reviews. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/session/blimp_engine_session.cc
diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc
index 06f1faf1c4d105fb3b0a0b55079377acebb2e769..5017d5ea112abde56d74deb4039db0913764de16 100644
--- a/blimp/engine/session/blimp_engine_session.cc
+++ b/blimp/engine/session/blimp_engine_session.cc
@@ -260,6 +260,8 @@ void BlimpEngineSession::Initialize() {
RegisterFeatures();
+ browser_context_->Initialize();
Wez 2016/04/26 01:38:19 nit: Add a one-line comment to explain what this i
Jess 2016/04/26 21:24:11 Done.
+
// Initialize must only be posted after the RegisterFeature calls have
// completed.
content::BrowserThread::PostTask(
@@ -269,6 +271,10 @@ void BlimpEngineSession::Initialize() {
engine_config_->client_token()));
}
+void BlimpEngineSession::Finalize() {
+ browser_context_->Finalize();
Wez 2016/04/26 01:38:19 Is it important that this happen before we enter t
Jess 2016/04/26 21:24:11 Done. Also moved call to browser_context_->Initia
+}
+
void BlimpEngineSession::RegisterFeatures() {
thread_pipe_manager_.reset(new ThreadPipeManager(
content::BrowserThread::GetMessageLoopProxyForThread(
« blimp/engine/session/blimp_engine_session.h ('K') | « blimp/engine/session/blimp_engine_session.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698