Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: blimp/engine/common/blimp_browser_context.h

Issue 1885673003: Create and integrate a metrics service client into Blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean ups from initial reviews. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/common/blimp_browser_context.h
diff --git a/blimp/engine/common/blimp_browser_context.h b/blimp/engine/common/blimp_browser_context.h
index e02f8316a035d7c664a56e02dd1ce6a5dabf55e4..35e22a0b541f07b1e9ae22daa8b0da33515da11e 100644
--- a/blimp/engine/common/blimp_browser_context.h
+++ b/blimp/engine/common/blimp_browser_context.h
@@ -9,6 +9,7 @@
#include "base/files/file_path.h"
#include "base/macros.h"
+#include "blimp/engine/app/blimp_metrics_service_client.h"
#include "blimp/engine/app/blimp_system_url_request_context_getter.h"
#include "blimp/engine/app/blimp_url_request_context_getter.h"
#include "content/public/browser/browser_context.h"
@@ -32,6 +33,10 @@ class BlimpBrowserContext : public content::BrowserContext {
BlimpBrowserContext(bool off_the_record, net::NetLog* net_log);
~BlimpBrowserContext() override;
+ // These map to BrowserMainParts::Pre/PostMainMessageLoopRun.
Wez 2016/04/26 01:38:19 nit: Do you mean "Called by BrowserMainParts::Pre/
Jess 2016/04/26 21:24:11 Yes. Done.
+ void Initialize();
+ void Finalize();
+
// content::BrowserContext implementation.
std::unique_ptr<content::ZoomLevelDelegate> CreateZoomLevelDelegate(
const base::FilePath& partition_path) override;
@@ -66,7 +71,10 @@ class BlimpBrowserContext : public content::BrowserContext {
// Performs initialization of the BlimpBrowserContext while IO is still
// allowed on the current thread.
void InitWhileIOAllowed();
+ void InitPrefService();
Wez 2016/04/26 01:38:19 nit: Blank line above this so it doesn't look like
Jess 2016/04/26 21:24:11 Done.
+ // Used by metrics service to persist logs and other information.
+ std::unique_ptr<PrefService> pref_service_;
Wez 2016/04/26 01:38:19 nit: Blank line after this, to separate it from th
Jess 2016/04/26 21:24:11 Done.
std::unique_ptr<BlimpResourceContext> resource_context_;
scoped_refptr<BlimpSystemURLRequestContextGetter> system_context_getter_;
bool ignore_certificate_errors_;

Powered by Google App Engine
This is Rietveld 408576698