Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Side by Side Diff: blimp/engine/session/blimp_engine_session.h

Issue 1885673003: Create and integrate a metrics service client into Blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean ups from initial reviews. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_ 5 #ifndef BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_
6 #define BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_ 6 #define BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 BlimpEngineSession(std::unique_ptr<BlimpBrowserContext> browser_context, 77 BlimpEngineSession(std::unique_ptr<BlimpBrowserContext> browser_context,
78 net::NetLog* net_log, 78 net::NetLog* net_log,
79 BlimpEngineConfig* config, 79 BlimpEngineConfig* config,
80 SettingsManager* settings_manager); 80 SettingsManager* settings_manager);
81 ~BlimpEngineSession() override; 81 ~BlimpEngineSession() override;
82 82
83 // Starts the network stack on the IO thread, and sets default placeholder 83 // Starts the network stack on the IO thread, and sets default placeholder
84 // values for e.g. screen size pending real values being supplied by the 84 // values for e.g. screen size pending real values being supplied by the
85 // client. 85 // client.
86 void Initialize(); 86 void Initialize();
87 // Finalizes the metrics reporting client.
Wez 2016/04/26 01:38:19 nit: Blank line before this comment, plz, to match
Jess 2016/04/26 21:24:11 Done.
88 void Finalize();
87 89
88 BlimpBrowserContext* browser_context() { return browser_context_.get(); } 90 BlimpBrowserContext* browser_context() { return browser_context_.get(); }
89 91
90 // BlimpMessageProcessor implementation. 92 // BlimpMessageProcessor implementation.
91 // This object handles incoming TAB_CONTROL and NAVIGATION messages directly. 93 // This object handles incoming TAB_CONTROL and NAVIGATION messages directly.
92 void ProcessMessage(std::unique_ptr<BlimpMessage> message, 94 void ProcessMessage(std::unique_ptr<BlimpMessage> message,
93 const net::CompletionCallback& callback) override; 95 const net::CompletionCallback& callback) override;
94 96
95 private: 97 private:
96 // Creates ThreadPipeManager, registers features, and then starts to accept 98 // Creates ThreadPipeManager, registers features, and then starts to accept
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 std::unique_ptr<BlimpMessageProcessor> tab_control_message_sender_; 215 std::unique_ptr<BlimpMessageProcessor> tab_control_message_sender_;
214 std::unique_ptr<BlimpMessageProcessor> navigation_message_sender_; 216 std::unique_ptr<BlimpMessageProcessor> navigation_message_sender_;
215 217
216 DISALLOW_COPY_AND_ASSIGN(BlimpEngineSession); 218 DISALLOW_COPY_AND_ASSIGN(BlimpEngineSession);
217 }; 219 };
218 220
219 } // namespace engine 221 } // namespace engine
220 } // namespace blimp 222 } // namespace blimp
221 223
222 #endif // BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_ 224 #endif // BLIMP_ENGINE_SESSION_BLIMP_ENGINE_SESSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698