Create and integrate a metrics service client into Blimp engine.

blimp/engine/common/blimp_browser_context.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/common/blimp_browser_context.h"
 
 #include "base/bind.h"
 #include "base/environment.h"
 #include "base/files/file_util.h"
+#include "base/memory/ptr_util.h"
 #include "base/nix/xdg_util.h"
 #include "base/path_service.h"
 #include "blimp/engine/app/blimp_permission_manager.h"
+#include "components/metrics/metrics_service.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+#include "components/prefs/in_memory_pref_store.h"
+#include "components/prefs/pref_service.h"
+#include "components/prefs/pref_service_factory.h"
 #include "content/public/browser/background_sync_controller.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/common/content_switches.h"
 
+namespace {
+// Shows notifications which correspond to PersistentPrefStore's reading errors.

[Wez, 2016/04/26 01:38:19]

Looks like the body of this function is missing?  Is it supposed to be declared
in-line?

[Jess, 2016/04/26 21:24:11]

PTAL at the new comment.

+void HandleReadError(PersistentPrefStore::PrefReadError error) {
+}
+}  // namespace
+
 namespace blimp {
 namespace engine {
 
 // Contains URLRequestContextGetter required for resource loading.
 class BlimpResourceContext : public content::ResourceContext {
  public:
   BlimpResourceContext() {}
   ~BlimpResourceContext() override {}
 
   void set_url_request_context_getter(
@@ skipping 33 matching lines @@
   InitWhileIOAllowed();
 }
 
 BlimpBrowserContext::~BlimpBrowserContext() {
   if (resource_context_) {
     content::BrowserThread::DeleteSoon(content::BrowserThread::IO, FROM_HERE,
                                        resource_context_.release());
   }
 }
 
+void BlimpBrowserContext::Initialize() {
+  InitPrefService();
+  BlimpMetricsServiceClient::GetInstance()->Initialize(
+      pref_service_.get(),
+      GetSystemRequestContextGetter());
+}
+
+void BlimpBrowserContext::Finalize() {
+  BlimpMetricsServiceClient::GetInstance()->Finalize();
+}
+
 void BlimpBrowserContext::InitWhileIOAllowed() {
   // Ensures ~/.config/blimp_engine directory exists.
   std::unique_ptr<base::Environment> env(base::Environment::Create());
   base::FilePath config_dir(base::nix::GetXDGDirectory(
       env.get(), base::nix::kXdgConfigHomeEnvVar, base::nix::kDotConfigDir));
   path_ = config_dir.Append("blimp_engine");
   if (!base::PathExists(path_))
     base::CreateDirectory(path_);
   BrowserContext::Initialize(this, path_);
 }
 
+void BlimpBrowserContext::InitPrefService() {

[Wez, 2016/04/26 01:38:19]

If I understand this code correctly (big "if") this is doing three things:

1. Creating a PrefRegistry & registering the metrics service preferences with
it.

2. Creating an in-memory preferences store, to hold metrics logs

3. Attaching it to that registry.

It would therefore be helpful to break this code up into logical blocks with
blob-level comments, i.e. something like:

  // Create a PrefRegistry and populate it with MetricsService prefs.
  ...

  // Create an in-memory PrefStore.
  ...

  // Create a PrefService binding the metrics PrefRegistry to our in-memory
store.
  ...

nit: It's also really unfortunate that those interfaces use bare pointers when
many of the objects being passed-around are ref-counted, but I don't think
there's much we can do about that in this CL, except perhaps mentioning in that
third comment that the PrefService ends up owning the PrefRegistry and store.
;-(

[Jess, 2016/04/26 21:24:11]

Done.

+  scoped_refptr<user_prefs::PrefRegistrySyncable> pref_registry(
+      new user_prefs::PrefRegistrySyncable());
+  metrics::MetricsService::RegisterPrefs(pref_registry.get());
+  PrefServiceFactory pref_service_factory;
+  // The pref storage for metrics logs.
+  pref_service_factory.set_user_prefs(new InMemoryPrefStore());
+  pref_service_factory.set_read_error_callback(base::Bind(&HandleReadError));
+  pref_service_ = pref_service_factory.Create(pref_registry.get());
+}
+
 std::unique_ptr<content::ZoomLevelDelegate>
 BlimpBrowserContext::CreateZoomLevelDelegate(const base::FilePath&) {
   return nullptr;
 }
 
 base::FilePath BlimpBrowserContext::GetPath() const {
   return path_;
 }
 
 bool BlimpBrowserContext::IsOffTheRecord() const {
@@ skipping 75 matching lines @@
 
 net::URLRequestContextGetter*
 BlimpBrowserContext::CreateMediaRequestContextForStoragePartition(
     const base::FilePath& partition_path,
     bool in_memory) {
   return nullptr;
 }
 
 }  // namespace engine
 }  // namespace blimp