Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1885663002: EDK: Add implementation of data pipe producer write threshold stuff. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add implementation of data pipe producer write threshold stuff. Entirely analogous to afe7672f3020a8b28fdbb316b3f7f91dcdd35ad0, which did this for read threshold stuff. * Mostly, "consumer" -> "producer", "read" -> "write", etc. * Also doesn't expose thunks yet. (But does expose new handle signal.) * The only non-mechanical changes versus the aforementioned change are in {LocalDataPipeImpl,RemoteConsumerDataPipeImpl}:: ProducerGetHandleSignalsState() (these are essentially the same) and DataPipeImplTest.WriteThreshold. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2e39898acbbbceb386b71b54c0b1bfef1210fa63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -33 lines) Patch
M mojo/edk/system/core.h View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 3 chunks +95 lines, -5 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 3 chunks +12 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 12 chunks +196 lines, -16 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 2 chunks +46 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 2 chunks +11 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_consumer_data_pipe_impl.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 8 months ago (2016-04-12 17:56:05 UTC) #1
viettrungluu
(this too, in case you missed it)
4 years, 8 months ago (2016-04-12 22:21:06 UTC) #2
vardhan
lgtm
4 years, 8 months ago (2016-04-13 00:52:35 UTC) #3
viettrungluu
4 years, 8 months ago (2016-04-13 06:00:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e39898acbbbceb386b71b54c0b1bfef1210fa63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698